Modifying make_env function to enable task information to propagate#41
Open
nikhilpinnaparaju wants to merge 5 commits into2.0from
Open
Modifying make_env function to enable task information to propagate#41nikhilpinnaparaju wants to merge 5 commits into2.0from
nikhilpinnaparaju wants to merge 5 commits into2.0from
Conversation
jsuarez5341
requested changes
Jul 11, 2023
Collaborator
jsuarez5341
left a comment
jsuarez5341
left a comment
There was a problem hiding this comment.
Looks good, minor changes required
| help="path to model to load (default: None)") | ||
| parser.add_argument( | ||
| "--model.type", | ||
| dest="model_type", type=str, default="realikun", |
Collaborator
There was a problem hiding this comment.
Avoid changing default args for testing when possible. Quick check for this is to just run a diff on the train script
train.py
Outdated
| make_task_fn = lambda: tasks | ||
|
|
||
| # env = nmmo.Env(config) | ||
| class MyNMMO(nmmo.Env): |
Collaborator
There was a problem hiding this comment.
I said MyNMMO as an indicator to override the class name -- call it TestTaskNMMO or something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying make_env function to enable task information to propagate